how to avoid runtime error while displaying a message box in excel vba -

-

i trying display message box saying "file not chosen" if file not chosen.my problem message box getting displayed when click on ok runtime error 1004 saying "file not found or check spelling , location of file".can me how avoid error.thank you

dim wbk1 workbook, wbk2 workbook, wbk3 workbook dim sh1 worksheet, sh2 worksheet, sh3 worksheet dim tmp1 string, tmp2 string, tmp3 string dim textbox1 string dim textbox2 string dim textbox3 string   tmp1 = sheets("sheet1").textbox1.value if len(trim(tmp1)) = 0 msgbox "file not chosen" end if exit sub tmp2 = sheets("sheet1").textbox2.value if len(trim(tmp2)) = 0 msgbox "destination file not selected" end if exit sub tmp3 = sheets("sheet1").textbox3.value if len(trim(tmp3)) = 0 msgbox "mapping file not selected" end if exit sub   set wbk1 = workbooks.open(tmp1) set wbk2 = workbooks.open(tmp2) set wbk3 = workbooks.open(tmp3)  set sh1 = wbk1.sheets("inventory") set sh2 = wbk2.sheets("inventory") set sh3 = wbk3.sheets("sheet1")

as john mentioned, have use exit for. using them @ wrong place.

also bad idea declare control variable. yes, referring 

dim textbox1 string dim textbox2 string dim textbox3 string

try this

sub sample()     dim wbk1 workbook, wbk2 workbook, wbk3 workbook     dim sh1 worksheet, sh2 worksheet, sh3 worksheet     dim tmp1 string, tmp2 string, tmp3 string      tmp1 = thisworkbook.sheets("sheet1").textbox1.value      if len(trim(tmp1)) = 0         msgbox "file not chosen"         exit sub     end if      tmp2 = thisworkbook.sheets("sheet1").textbox2.value      if len(trim(tmp2)) = 0         msgbox "destination file not selected"         exit sub     end if      tmp3 = thisworkbook.sheets("sheet1").textbox3.value      if len(trim(tmp3)) = 0         msgbox "mapping file not selected"         exit sub     end if      set wbk1 = workbooks.open(tmp1)     set wbk2 = workbooks.open(tmp2)     set wbk3 = workbooks.open(tmp3)      set sh1 = wbk1.sheets("inventory")     set sh2 = wbk2.sheets("inventory")     set sh3 = wbk3.sheets("sheet1") end sub

after doing this, if still message "file not found or check spelling , location of file" means path mentioned in textbox not correct. can use dir check if path correct or not.

for example 

 if dir(tmp1) = ""      msgbox "incorrect path/file. please ensure textbox has correct path"  else      set wbk1 = workbooks.open(tmp1)  end if

Comments

Post a Comment

Popular posts from this blog

python - Subclassed QStyledItemDelegate ignores Stylesheet -

-
i'm trying subclass qstyleditemdelegate remove focus rectangle in qcombobox . even though i'm calling base implementation of paint function , nothing else, result different. looks if parts of style-sheet influence bounding box of item taken consideration. class pstyleditemdelegate(qstyleditemdelegate): def __init__(self, *args, **kwds): super(pstyleditemdelegate, self).__init__(*args, **kwds) def paint(self, *args, **kwargs): qstyleditemdelegate.paint(*args, **kwargs) what have paint unmodified qstyleditemdelegate ? as suggested tried replacing pyside pyqt4 , works, appears bug. update pyside 1.1.2 1.2.1 result same. unfortunately switch breaks other parts of code, if there no other suggestions i'm going accept answer. edit bug tracked here
Read more

node.js - StackOverflow API not returning JSON -

-
i using node.js script gather data stackoverflow. know responses gzipped, put code in should take care of that. script follows: var request = require('request'); var zlib = require('zlib'); function getstackoverflowresponse(url, callback){ request(url, {encoding: null}, function(err, response, body){ if(response.headers['content-encoding'] == 'gzip'){ zlib.gunzip(body, function(err, dezipped) { callback(dezipped); }); } else { callback(body); } }); } var url = "https://api.stackexchange.com/docs/questions#pagesize=2&order=desc&min=2014-01-04&max=2014-02-02&sort=activity&tagged=apigee&filter=default&site=stackoverflow&run=true"; getstackoverflowresponse(url, function(questions) { console.log(questions); }); instead of getting json output, i'm getting following response: buffer 0d 0a 0d 0a 0d 0a 0d 0a 3c 21 44 4f 43 54 59 50 45 20 48...
Read more

java - HttpClient 3.1 Connection pooling vs HttpClient 4.3.2 -

-
i have used httpclient3.1(java) connection pooling below : import org.apache.commons.httpclient.httpclient; import org.apache.commons.httpclient.multithreadedhttpconnectionmanager; import org.apache.commons.httpclient.params.httpclientparams; import org.apache.commons.httpclient.params.httpmethodparams; import org.apache.log4j.logger; public class httpclientmanager { private static logger logger = logger.getlogger(httpclientmanager.class); private static multithreadedhttpconnectionmanager connectionmanager = new multithreadedhttpconnectionmanager(); private static httpclientparams clientparams = new httpclientparams(); static { try { clientparams.makelenient(); clientparams.setauthenticationpreemptive(false); clientparams.setparameter(httpmethodparams.so_timeout, new integer(30000)); // set so_timeout clientparams.setparameter(httpmethodparams.head_body_check_timeout, new integer(3000)); // head responses ...
Read more