javascript - KineticJS Undo layers: layers don't disappear on undo? -

-

i have specific problem on designer drawing tool in canvas html5. developing action history system (undo & redo). building system on projeqht's answer on this question serializing layers in history array. core, idea of solution working have strange problem. when hit undo creates new layers, old ones not disappearing. attach sourcecode , attach screenshots can see happening:

sourcecode:

var history = array(null);

var historystep = 0;

var arraynonremovable = array('movelayer', 'scalefromouternode', 'scalefrominnernode', 'rotatefromoutersign', 'rotatefrominnersign' );

function removelayerbyundoredo(l) { if (l) { l.destroy(); l.draw(); stage.draw(); } }

function makehistory(layer, before, after, operation) { historystep++; if (historystep

function undohistory() { if (historystep>0) { version = history[historystep]; layer = version.layer; var beforestate = history[historystep].before;

    removelayerbyundoredo(layer);     var layer = kinetic.node.create(beforestate, 'container');     stage.add(layer);      stage.draw();     historystep--; }

}

array.prototype.contains = function(obj) { return this.indexof(obj) > -1; };

screenshots: step 1. create object, contains more groups shapes inside (lines, rectangles, svg drawing) creating object steps 2, 3, 4, 5: moving object different positions (top left, bottom left, bottom right , top right): enter image description here enter image description here enter image description here enter image description here step 6: press undo first time (removes old layer , recreates history well): enter image description here step 7: press undo second time (creates new layer history, old layer not removed) enter image description here step 8, 9: press undo 2 times (same happens in step 7: creates new layer old ones remain): enter image description here

am doing wrong? think must reference new layers in step 6 removed layers reference original layer, in following steps new layers, reference should new one?

after serialize layer json, must 

yourlayer.destroy()

your code seems need more code find what's going wrong.

a long-shot possibility:

i see undohistory references global layer , creates local layer. try refactoring code sure you're not mixing different "layer":

function undohistory(){    if (historystep>0){       var version = history[historystep];       var beforestate = history[historystep].before;       var layer1 = version.layer;       removelayerbyundoredo(layer1);       var layer2 = kinetic.node.create(beforestate, 'container');       stage.add(layer2);       stage.draw();       historystep--;     } }

you don't need l.draw() or stage.draw() after l.destroy() because layer being destroyed anyway , stage auto-updated when layer destroyed.

here working example of layer.destroy may until can post more code:

http://jsfiddle.net/m1erickson/fsbbn/


Comments

Post a Comment

Popular posts from this blog

python - Subclassed QStyledItemDelegate ignores Stylesheet -

-
i'm trying subclass qstyleditemdelegate remove focus rectangle in qcombobox . even though i'm calling base implementation of paint function , nothing else, result different. looks if parts of style-sheet influence bounding box of item taken consideration. class pstyleditemdelegate(qstyleditemdelegate): def __init__(self, *args, **kwds): super(pstyleditemdelegate, self).__init__(*args, **kwds) def paint(self, *args, **kwargs): qstyleditemdelegate.paint(*args, **kwargs) what have paint unmodified qstyleditemdelegate ? as suggested tried replacing pyside pyqt4 , works, appears bug. update pyside 1.1.2 1.2.1 result same. unfortunately switch breaks other parts of code, if there no other suggestions i'm going accept answer. edit bug tracked here
Read more

java - HttpClient 3.1 Connection pooling vs HttpClient 4.3.2 -

-
i have used httpclient3.1(java) connection pooling below : import org.apache.commons.httpclient.httpclient; import org.apache.commons.httpclient.multithreadedhttpconnectionmanager; import org.apache.commons.httpclient.params.httpclientparams; import org.apache.commons.httpclient.params.httpmethodparams; import org.apache.log4j.logger; public class httpclientmanager { private static logger logger = logger.getlogger(httpclientmanager.class); private static multithreadedhttpconnectionmanager connectionmanager = new multithreadedhttpconnectionmanager(); private static httpclientparams clientparams = new httpclientparams(); static { try { clientparams.makelenient(); clientparams.setauthenticationpreemptive(false); clientparams.setparameter(httpmethodparams.so_timeout, new integer(30000)); // set so_timeout clientparams.setparameter(httpmethodparams.head_body_check_timeout, new integer(3000)); // head responses ...
Read more

node.js - StackOverflow API not returning JSON -

-
i using node.js script gather data stackoverflow. know responses gzipped, put code in should take care of that. script follows: var request = require('request'); var zlib = require('zlib'); function getstackoverflowresponse(url, callback){ request(url, {encoding: null}, function(err, response, body){ if(response.headers['content-encoding'] == 'gzip'){ zlib.gunzip(body, function(err, dezipped) { callback(dezipped); }); } else { callback(body); } }); } var url = "https://api.stackexchange.com/docs/questions#pagesize=2&order=desc&min=2014-01-04&max=2014-02-02&sort=activity&tagged=apigee&filter=default&site=stackoverflow&run=true"; getstackoverflowresponse(url, function(questions) { console.log(questions); }); instead of getting json output, i'm getting following response: buffer 0d 0a 0d 0a 0d 0a 0d 0a 3c 21 44 4f 43 54 59 50 45 20 48...
Read more